gui: update Qt base translations for macOS release
ClosedPublic
Actions

Authored by Fabien on Sep 29 2020, 14:17.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC2e944f6e3bd3: gui: update Qt base translations for macOS release

Summary

These haven't been updated since their addition, so this updates the
list that controls which qt base translations are bundled with the macOS
binary, to all the languages that are available with qt 5.9.8.

This could probably be improved in some way, however qt updates are
infrequent, and I didn't want to spend any more time looking at this.
Also given that no-one seems to have noticed and/or reported this it
wouldn't seem high-priority.

Backport of core PR19059.

Test Plan

Run the OSX gitian build and run the GUI.
I couldn't reproduce the screenshots from the PR, I don't know what
setting can cause this, but the GUI still runs fine.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 29 2020, 14:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 14:17

Fabien requested review of this revision.Sep 29 2020, 14:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13053: Diff 24031.Sep 29 2020, 14:28

deadalnix requested changes to this revision.Sep 29 2020, 14:50

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/CMakeLists.txt
429 ↗	(On Diff #24031)	This name change isn't part of the PR. What happened?

This revision now requires changes to proceed.Sep 29 2020, 14:50

Fabien requested review of this revision.Sep 29 2020, 15:03

Fabien added inline comments.

src/qt/CMakeLists.txt
429 ↗	(On Diff #24031)	The previous name was pretty bad. These are the translation files that are shipped with Qt, but `QT_INSTALLER_SUPPORTED_LANGUAGES` makes you think that they are the translation used for some installation program GUI which doesn't exist. Since the PR title references these as Qt base translations, I used the occasion to update the name. I can split it apart if you prefer.