Differential D7686
[backport#17371 1/2] Accumulate result UniValue in SignTransaction Authored by majcosta on Sep 30 2020, 20:38. Tags None Subscribers None
Details
SignTransaction will be called multiple times in the future. Pass https://github.com/bitcoin/bitcoin/pull/17371/commits/4b0c718f8f48c678cbe4575e9a9cf9e62a30f0da Partial backport of Core PR17371 ninja check check-functional
Diff Detail
Event TimelineComment Actions [Bot Message] Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Snippet of first build failure: [341/402] Running utility command for check-bitcoin-torcontrol_tests [342/402] bitcoin: testing settings_tests [343/402] bitcoin: testing sigencoding_tests [344/402] bitcoin: testing timedata_tests [345/402] bitcoin: testing streams_tests [346/402] Running utility command for check-bitcoin-settings_tests [347/402] Running utility command for check-bitcoin-sigencoding_tests [348/402] Running utility command for check-bitcoin-streams_tests [349/402] Running utility command for check-bitcoin-timedata_tests [350/402] bitcoin: testing uint256_tests [351/402] bitcoin: testing undo_tests [352/402] bitcoin: testing util_threadnames_tests [353/402] Running utility command for check-bitcoin-uint256_tests [354/402] Running utility command for check-bitcoin-undo_tests [355/402] Running utility command for check-bitcoin-util_threadnames_tests [356/402] bitcoin: testing walletdb_tests [357/402] Running utility command for check-bitcoin-walletdb_tests [358/402] bitcoin: testing serialize_tests [359/402] bitcoin: testing validationinterface_tests [360/402] Running utility command for check-bitcoin-serialize_tests [361/402] Running utility command for check-bitcoin-validationinterface_tests [362/402] bitcoin: testing script_standard_tests [363/402] Running utility command for check-bitcoin-script_standard_tests [364/402] bitcoin: testing radix_tests [365/402] Running utility command for check-bitcoin-radix_tests [366/402] bitcoin: testing blockstatus_tests [367/402] Running utility command for check-bitcoin-blockstatus_tests [368/402] bitcoin: testing blockcheck_tests [369/402] bitcoin: testing crypto_tests [370/402] Running utility command for check-bitcoin-blockcheck_tests [371/402] bitcoin: testing ismine_tests [372/402] Running utility command for check-bitcoin-crypto_tests [373/402] Running utility command for check-bitcoin-ismine_tests [374/402] bitcoin: testing validation_block_tests [375/402] bitcoin: testing cashaddr_tests [376/402] Running utility command for check-bitcoin-validation_block_tests [377/402] bitcoin: testing getarg_tests [378/402] Running utility command for check-bitcoin-cashaddr_tests [379/402] bitcoin: testing versionbits_tests [380/402] Running utility command for check-bitcoin-getarg_tests [381/402] Running utility command for check-bitcoin-versionbits_tests [382/402] bitcoin: testing script_tests [383/402] bitcoin: testing bswap_tests [384/402] Running utility command for check-bitcoin-script_tests [385/402] Running utility command for check-bitcoin-bswap_tests [386/402] bitcoin: testing validation_tests [387/402] Running utility command for check-bitcoin-validation_tests [388/402] bitcoin: testing skiplist_tests [389/402] Running utility command for check-bitcoin-skiplist_tests [390/402] bitcoin: testing util_tests [391/402] Running utility command for check-bitcoin-util_tests [392/402] bitcoin: testing transaction_tests [393/402] Running utility command for check-bitcoin-transaction_tests [394/402] bitcoin: testing op_reversebytes_tests [395/402] Running utility command for check-bitcoin-op_reversebytes_tests [396/402] bitcoin: testing cuckoocache_tests [397/402] Running utility command for check-bitcoin-cuckoocache_tests [398/402] bitcoin: testing coins_tests [399/402] Running utility command for check-bitcoin-coins_tests Build build-clang-tidy timed out after 1800.0s Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Snippet of first build failure: [348/409] Running utility command for check-bitcoin-schnorr_tests [349/409] bitcoin: testing settings_tests [350/409] Running utility command for check-bitcoin-settings_tests [351/409] bitcoin: testing streams_tests [352/409] bitcoin: testing timedata_tests [353/409] Running utility command for check-bitcoin-streams_tests [354/409] Running utility command for check-bitcoin-timedata_tests [355/409] bitcoin: testing uint256_tests [356/409] bitcoin: testing checkdatasig_tests [357/409] Running utility command for check-bitcoin-uint256_tests [358/409] Running utility command for check-bitcoin-checkdatasig_tests [359/409] bitcoin: testing walletdb_tests [360/409] Running utility command for check-bitcoin-walletdb_tests [361/409] bitcoin: testing undo_tests [362/409] Running utility command for check-bitcoin-undo_tests [363/409] bitcoin: testing util_threadnames_tests [364/409] bitcoin: testing serialize_tests [365/409] Running utility command for check-bitcoin-util_threadnames_tests [366/409] Running utility command for check-bitcoin-serialize_tests [367/409] bitcoin: testing script_standard_tests [368/409] Running utility command for check-bitcoin-script_standard_tests [369/409] bitcoin: testing sigencoding_tests [370/409] bitcoin: testing crypto_tests [371/409] Running utility command for check-bitcoin-sigencoding_tests [372/409] Running utility command for check-bitcoin-crypto_tests [373/409] bitcoin: testing radix_tests [374/409] bitcoin: testing blockstatus_tests [375/409] bitcoin: testing versionbits_tests [376/409] Running utility command for check-bitcoin-radix_tests [377/409] Running utility command for check-bitcoin-blockstatus_tests [378/409] Running utility command for check-bitcoin-versionbits_tests [379/409] bitcoin: testing blockcheck_tests [380/409] bitcoin: testing ismine_tests [381/409] bitcoin: testing validation_block_tests [382/409] Running utility command for check-bitcoin-ismine_tests [383/409] Running utility command for check-bitcoin-blockcheck_tests [384/409] Running utility command for check-bitcoin-validation_block_tests [385/409] bitcoin: testing cashaddr_tests [386/409] bitcoin: testing getarg_tests [387/409] bitcoin: testing validation_tests [388/409] Running utility command for check-bitcoin-cashaddr_tests [389/409] Running utility command for check-bitcoin-getarg_tests [390/409] Running utility command for check-bitcoin-validation_tests [391/409] bitcoin: testing bswap_tests [392/409] Running utility command for check-bitcoin-bswap_tests [393/409] bitcoin: testing script_tests [394/409] bitcoin: testing skiplist_tests [395/409] Running utility command for check-bitcoin-script_tests [396/409] Running utility command for check-bitcoin-skiplist_tests [397/409] bitcoin: testing util_tests [398/409] Running utility command for check-bitcoin-util_tests [399/409] bitcoin: testing op_reversebytes_tests [400/409] Running utility command for check-bitcoin-op_reversebytes_tests [401/409] bitcoin: testing cuckoocache_tests [402/409] Running utility command for check-bitcoin-cuckoocache_tests [403/409] bitcoin: testing coins_tests [404/409] Running utility command for check-bitcoin-coins_tests [405/409] bitcoin: testing transaction_tests [406/409] Running utility command for check-bitcoin-transaction_tests Build build-clang timed out after 1200.0s |