Page MenuHomePhabricator
Differential D7692

[backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize
ClosedPublic
Actions

Authored by majcosta on Sep 30 2020, 22:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC903e524b88fd: [backport#17553] wallet: Remove out of date comments for…
Summary

6a2e6b0600077e5903400dc74bc8b0c26592fde6 Remove out of date comments for CalculateMaximumSignedTxSize (Gregory Sanders)

Pull request description:

These paths can be hit for probably a number of reasons, and ISMINE spendability is not a requirement to call it.

For example: During watch-only transaction creation, previous transaction in wallet, pubkey imported, but not the witnessscript associated with the prevout.

In this case I think no/minimal comment is better than specific and soon to be out of date.

Backport of Core PR17553

Test Plan
read them

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 30 2020, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2020, 22:53
majcosta requested review of this revision.Sep 30 2020, 22:53
teamcity edited the summary of this revision. (Show Details)Sep 30 2020, 22:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Sep 30 2020, 23:01
This revision is now accepted and ready to land.Sep 30 2020, 23:01
This revision was landed with ongoing or failed builds.Sep 30 2020, 23:13
Closed by commit rABC903e524b88fd: [backport#17553] wallet: Remove out of date comments for… (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC903e524b88fd: [backport#17553] wallet: Remove out of date comments for….
Harbormaster completed remote builds in B13087: Diff 24084.Sep 30 2020, 23:31

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines

Diff 24086

View Options

src/wallet/wallet.cpp

Loading...