HomePhabricator

[backport#17553] wallet: Remove out of date comments for…

Description

[backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize

Summary:
6a2e6b0600077e5903400dc74bc8b0c26592fde6 Remove out of date comments for CalculateMaximumSignedTxSize (Gregory Sanders)

Pull request description:

These paths can be hit for probably a number of reasons, and ISMINE spendability is not a requirement to call it.

For example: During watch-only transaction creation, previous transaction in wallet, pubkey imported, but not the witnessscript associated with the prevout.

In this case I think no/minimal comment is better than specific and soon to be out of date.

Backport of Core PR17553

Test Plan:

read them

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7692

Details

Provenance
Samuel Dobson <dobsonsa68@gmail.com>Authored on Nov 22 2019, 20:33
majcostaCommitted on Sep 30 2020, 23:13
majcostaPushed on Sep 30 2020, 23:13
Reviewer
Restricted Project
Differential Revision
D7692: [backport#17553] wallet: Remove out of date comments for CalculateMaximumSignedTxSize
Parents
rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and…
Branches
Unknown
Tags
Unknown