Fix assertion in CKey::SignCompact
ClosedPublic
Actions

Authored by PiRK on Oct 1 2020, 13:30.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC0c7574e08812: Fix assertion in CKey::SignCompact

Summary

The second assertion was testing the same condition as the first one.

Backport of Core PR15299

Test Plan

ninja && ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 1 2020, 13:30

Owners added a reviewer: Restricted Owners Package.Oct 1 2020, 13:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 13:30

PiRK requested review of this revision.Oct 1 2020, 13:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This is not a PR

This revision now requires changes to proceed.Oct 1 2020, 13:42

fix PR number (15299)

deadalnix accepted this revision.Oct 1 2020, 14:11

Harbormaster completed remote builds in B13107: Diff 24120.Oct 1 2020, 14:14

Fabien accepted this revision.Oct 1 2020, 14:23

This revision is now accepted and ready to land.Oct 1 2020, 14:23

Harbormaster completed remote builds in B13112: Diff 24127.Oct 1 2020, 14:43

Closed by commit rABC0c7574e08812: Fix assertion in CKey::SignCompact (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 1 2020, 15:20

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0c7574e08812: Fix assertion in CKey::SignCompact.

Revision Contents
Changeset List

Path

Size

src/

key.cpp

2 lines

Diff 24148

View Options

Fix assertion in CKey::SignCompactClosedPublicActions