Page MenuHomePhabricator
Differential D7713

[backport#17447] wallet: Make -walletdir network only
ClosedPublic
Actions

Authored by majcosta on Oct 1 2020, 15:03.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4e8ce19c380e: [backport#17447] wallet: Make -walletdir network only
Summary

3c2c439dcd8797019ac6d6614775d5c20ee41c36 wallet: Make -walletdir network only (João Barbosa)

Pull request description:

With this PR `bitcoind -regtest` doesn't run if bitcoin.conf has
```
walletdir=/mnt/mydisk/wallets
```
But works with
```
[regtest]
walletdir=/mnt/mydisk/wallets
```

Doesn't change mainnet behavior.

Closes #15630.

Backport of Core PR17447

Test Plan
ninja all check check-functional

perform test in the summary

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 1 2020, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 15:03
majcosta requested review of this revision.Oct 1 2020, 15:03
teamcity edited the summary of this revision. (Show Details)Oct 1 2020, 15:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien accepted this revision.Oct 1 2020, 15:06
This revision is now accepted and ready to land.Oct 1 2020, 15:06
This revision was landed with ongoing or failed builds.Oct 1 2020, 15:14
Closed by commit rABC4e8ce19c380e: [backport#17447] wallet: Make -walletdir network only (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC4e8ce19c380e: [backport#17447] wallet: Make -walletdir network only.
Harbormaster completed remote builds in B13119: Diff 24140.Oct 1 2020, 15:38

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines

Diff 24145

View Options

src/wallet/init.cpp

Loading...