HomePhabricator

[backport#17447] wallet: Make -walletdir network only

Description

[backport#17447] wallet: Make -walletdir network only

Summary:
3c2c439dcd8797019ac6d6614775d5c20ee41c36 wallet: Make -walletdir network only (João Barbosa)

Pull request description:

With this PR `bitcoind -regtest` doesn't run if bitcoin.conf has
```
walletdir=/mnt/mydisk/wallets
```
But works with
```
[regtest]
walletdir=/mnt/mydisk/wallets
```

Doesn't change mainnet behavior.

Closes #15630.

Backport of Core PR17447

Test Plan:

ninja all check check-functional

perform test in the summary

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7713

Details

Provenance
Samuel Dobson <dobsonsa68@gmail.com>Authored on Nov 22 2019, 21:35
majcostaCommitted on Oct 1 2020, 15:13
majcostaPushed on Oct 1 2020, 15:14
Reviewer
Restricted Project
Differential Revision
D7713: [backport#17447] wallet: Make -walletdir network only
Parents
rABC6098a1cb2b25: [backport#17437] rpc: Expose block height of wallet transactions
Branches
Unknown
Tags
Unknown