Page MenuHomePhabricator
Differential D7717

Fix shadowing of bin Python keyword
ClosedPublic
Actions

Authored by jasonbcox on Oct 1 2020, 16:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbee6c23a30e6: Fix shadowing of bin Python keyword
Summary

bin is a Python built-in: https://docs.python.org/3/library/functions.html#bin

Test Plan

Run any build:
./build-configurations.py build-without-wallet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 1 2020, 16:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2020, 16:27
jasonbcox requested review of this revision.Oct 1 2020, 16:27
Harbormaster completed remote builds in B13125: Diff 24152.Oct 1 2020, 16:38
teamcity added a comment.Oct 1 2020, 16:38
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Snippet of first build failure:

[319/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[320/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[321/482] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[322/482] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[323/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[324/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[325/482] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[326/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/db.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-8;-warnings-as-errors=*" --source=../../src/wallet/db.cpp -- /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety-analysis -Wshadow -Wshadow-field -Wrange-loop-analysis -Wredundant-decls -Wformat-security -Wredundant-move -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++14 -MD -MT src/wallet/CMakeFiles/wallet.dir/db.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/db.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/db.cpp.o -c ../../src/wallet/db.cpp
/work/abc-ci-builds/build-clang-tidy/../../src/wallet/db.cpp:869:30: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
                if (!fMockDb) dbenv->lsn_reset(strFile.c_str(), 0);
                             ^
                              {
2458 warnings generated.
Suppressed 2457 warnings (2457 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[327/482] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[328/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[329/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[330/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[331/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[332/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[333/482] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[334/482] Linking CXX static library src/libutil.a
[335/482] Linking CXX static library src/libscript.a
[336/482] Linking CXX static library src/libcommon.a
[337/482] Linking CXX static library src/librpcclient.a
[338/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[339/482] Linking CXX executable src/bitcoin-cli
[340/482] Linking CXX static library src/libbitcoinconsensus.a
[341/482] Linking CXX shared library src/libbitcoinconsensus.so.0.22.4
[342/482] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[343/482] Linking CXX executable src/bitcoin-tx
[344/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[345/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[346/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[347/482] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[348/482] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[349/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[350/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[351/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[352/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[353/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[354/482] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[355/482] Linking CXX static library src/seeder/libseeder.a
[356/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[357/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[358/482] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[359/482] Linking CXX static library src/zmq/libzmq.a
[360/482] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[361/482] Linking CXX executable src/seeder/bitcoin-seeder
[362/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[363/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[364/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[365/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[366/482] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien accepted this revision.Oct 1 2020, 16:50
This revision is now accepted and ready to land.Oct 1 2020, 16:50
teamcity added a comment.Oct 1 2020, 16:58
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Snippet of first build failure:

[348/409] Running utility command for check-bitcoin-bip32_tests
[349/409] bitcoin: testing settings_tests
[350/409] Running utility command for check-bitcoin-sync_tests
[351/409] Running utility command for check-bitcoin-torcontrol_tests
[352/409] bitcoin: testing streams_tests
[353/409] Running utility command for check-bitcoin-settings_tests
[354/409] bitcoin: testing wallet_tests
[355/409] Running utility command for check-bitcoin-streams_tests
[356/409] bitcoin: testing timedata_tests
[357/409] Running utility command for check-bitcoin-wallet_tests
[358/409] Running utility command for check-bitcoin-timedata_tests
[359/409] bitcoin: testing uint256_tests
[360/409] bitcoin: testing undo_tests
[361/409] Running utility command for check-bitcoin-uint256_tests
[362/409] Running utility command for check-bitcoin-undo_tests
[363/409] bitcoin: testing util_threadnames_tests
[364/409] Running utility command for check-bitcoin-util_threadnames_tests
[365/409] bitcoin: testing walletdb_tests
[366/409] Running utility command for check-bitcoin-walletdb_tests
[367/409] bitcoin: testing checkqueue_tests
[368/409] bitcoin: testing script_standard_tests
[369/409] Running utility command for check-bitcoin-checkqueue_tests
[370/409] bitcoin: testing serialize_tests
[371/409] Running utility command for check-bitcoin-script_standard_tests
[372/409] Running utility command for check-bitcoin-serialize_tests
[373/409] bitcoin: testing radix_tests
[374/409] bitcoin: testing ismine_tests
[375/409] bitcoin: testing blockstatus_tests
[376/409] Running utility command for check-bitcoin-radix_tests
[377/409] Running utility command for check-bitcoin-ismine_tests
[378/409] bitcoin: testing versionbits_tests
[379/409] Running utility command for check-bitcoin-blockstatus_tests
[380/409] Running utility command for check-bitcoin-versionbits_tests
[381/409] bitcoin: testing crypto_tests
[382/409] Running utility command for check-bitcoin-crypto_tests
[383/409] bitcoin: testing cashaddr_tests
[384/409] bitcoin: testing getarg_tests
[385/409] bitcoin: testing validation_block_tests
[386/409] Running utility command for check-bitcoin-cashaddr_tests
[387/409] Running utility command for check-bitcoin-getarg_tests
[388/409] Running utility command for check-bitcoin-validation_block_tests
[389/409] bitcoin: testing bswap_tests
[390/409] Running utility command for check-bitcoin-bswap_tests
[391/409] bitcoin: testing validation_tests
[392/409] Running utility command for check-bitcoin-validation_tests
[393/409] bitcoin: testing script_tests
[394/409] Running utility command for check-bitcoin-script_tests
[395/409] bitcoin: testing skiplist_tests
[396/409] Running utility command for check-bitcoin-skiplist_tests
[397/409] bitcoin: testing util_tests
[398/409] Running utility command for check-bitcoin-util_tests
[399/409] bitcoin: testing op_reversebytes_tests
[400/409] bitcoin: testing cuckoocache_tests
[401/409] Running utility command for check-bitcoin-op_reversebytes_tests
[402/409] Running utility command for check-bitcoin-cuckoocache_tests
[403/409] bitcoin: testing coins_tests
[404/409] Running utility command for check-bitcoin-coins_tests
[405/409] bitcoin: testing transaction_tests
[406/409] Running utility command for check-bitcoin-transaction_tests
Build build-clang timed out after 1200.0s
This revision was landed with ongoing or failed builds.Oct 1 2020, 17:13
Closed by commit rABCbee6c23a30e6: Fix shadowing of bin Python keyword (authored by jasonbcox). · Explain Why
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCbee6c23a30e6: Fix shadowing of bin Python keyword.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
8 lines

Diff 24159

View Options

contrib/teamcity/build-configurations.py

Loading...