Page MenuHomePhabricator

Revert recent coin selection changes
ClosedPublic

Authored by jasonbcox on Oct 2 2020, 00:18.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC85f266319f58: Revert recent coin selection changes
Summary

Revert D7674 and D7691 (since it built on top of the prior).

D7674 is failing all sanitizer builds and appears to be adding flakiness
to ninja check in some configurations. There's hints that backporting up
to PR17261 may fix one or more of these problems. Until then, we should
revert as it's making diff tests unreliable and incredibly noisy, as
well as zero reliability on sanitizer builds.

I opted to revert them together as one patch in order to give us the
option of un-reverting them both as a single change (by reverting this
change).

This reverts commit 78322dfdfa3c31b410b227fcde1d611d6f6cb9d8 and 28efd9a54daa873afb4512911bcc8bb31b5cbda9

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Oct 2 2020, 01:15
This revision was automatically updated to reflect the committed changes.