Page MenuHomePhabricator
Differential D7674

Enable BnB coin selection for preset inputs and subtract fee from outputs
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 16:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs
Summary
  • Use BnB when preset inputs are selected
  • Allow BnB when subtract fee from outputs

This is a backport of Core PR17290

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 16:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 16:38
deadalnix requested review of this revision.Sep 29 2020, 16:38
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 16:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13057: Diff 24038.Sep 29 2020, 16:54
Fabien accepted this revision.Sep 30 2020, 09:59
This revision is now accepted and ready to land.Sep 30 2020, 09:59
Closed by commit rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhySep 30 2020, 10:10
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs.
jasonbcox added a reverting change: D7729: Revert recent coin selection changes.Oct 2 2020, 00:18
jasonbcox added a reverting change: rABC85f266319f58: Revert recent coin selection changes.Oct 2 2020, 02:03
jasonbcox mentioned this in T1092: Unrevert coin selection changes.Oct 6 2020, 21:32
jasonbcox mentioned this in D8015: Revert "Revert recent coin selection changes".Oct 21 2020, 00:12
jasonbcox mentioned this in rABC54fef78d5b20: Revert "Revert recent coin selection changes".Oct 21 2020, 18:44

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
56 lines
2 lines
107 lines

Diff 24052

View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...