Page MenuHomePhabricator

dead code: Remove dead option in HexStr conversion
ClosedPublic

Authored by PiRK on Oct 2 2020, 11:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb22266442d87: dead code: Remove dead option in HexStr conversion
Summary

Problem:

  • Nothing uses the fspaces argument to HexStr() besides unit tests. This argument results in extra complexity and a small performance decrease within the function for branch evalulation.

Solution:

  • Remove unused fspaces option.

Backport of Core PR15573

Test Plan

grep -r 'HexStr([^,]*,[^,]*,' src/
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 11:37
PiRK requested review of this revision.Oct 2 2020, 11:37
deadalnix requested changes to this revision.Oct 2 2020, 14:18
deadalnix added a subscriber: deadalnix.

It is generally not the best idea to take ownership of code from Core, unless we have a good reason to do so for some feature.

src/util/strencodings.h
138 ↗(On Diff #24201)

This adds a dependency on a whole header and isn't really that simpler.

This revision now requires changes to proceed.Oct 2 2020, 14:18
PiRK edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Oct 2 2020, 18:59