Paths

Table of Contentst

dead code: Remove dead option in HexStr conversion
ClosedPublic
Actions

Authored by PiRK on Oct 2 2020, 11:37.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCb22266442d87: dead code: Remove dead option in HexStr conversion

Summary

Problem:

Nothing uses the fspaces argument to HexStr() besides unit tests. This argument results in extra complexity and a small performance decrease within the function for branch evalulation.

Solution:

Remove unused fspaces option.

Backport of Core PR15573

Test Plan

grep -r 'HexStr([^,]*,[^,]*,' src/
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 2 2020, 11:37

Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 11:37

PiRK requested review of this revision.Oct 2 2020, 11:37

Harbormaster completed remote builds in B13154: Diff 24201.Oct 2 2020, 11:50

It is generally not the best idea to take ownership of code from Core, unless we have a good reason to do so for some feature.

src/util/strencodings.h
138 ↗	(On Diff #24201)	This adds a dependency on a whole header and isn't really that simpler.

This revision now requires changes to proceed.Oct 2 2020, 14:18

PiRK edited the summary of this revision. (Show Details)Oct 2 2020, 14:59

PiRK edited the test plan for this revision. (Show Details)

deadalnix accepted this revision.Oct 2 2020, 18:59

This revision is now accepted and ready to land.Oct 2 2020, 18:59

Closed by commit rABCb22266442d87: dead code: Remove dead option in HexStr conversion (authored by Lenny Maiorani <lenny@colorado.edu>, committed by PiRK). · Explain WhyOct 3 2020, 11:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb22266442d87: dead code: Remove dead option in HexStr conversion.

Revision Contents
Changeset List

Path

Size

src/

test/

util_tests.cpp

29 lines

util/

strencodings.h

13 lines

Diff 24237

View Options

src/test/util_tests.cpp