HomePhabricator

[rpc] deriveaddresses: add range to CRPCConvertParam

Description

[rpc] deriveaddresses: add range to CRPCConvertParam

Summary:
Related to D6614

Backport of Core PR15510

Test Plan:

ninja && ninja check
sudo ninja install

Before:

$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
error code: -8
error message:
Unknown named parameter range

After:

$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
[
  "bitcoincash:qprtnzgt6eph9hh0ejsn508qjjhspcagsses6cmsf0",
  "bitcoincash:qpqmyerc9q5atsvqlx668ulur2s2le36qv996lljtt",
  "bitcoincash:qz338f4ef5kl8ygqcwg822m99nyydq4lju7mlv08ny",
  "bitcoincash:qqe9495xzm8g80z9cm3angqq9pcn3978c5xuj82h68"
]

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7730

Details

Provenance
Sjors Provoost <sjors@sprovoost.nl>Authored on Mar 1 2019, 12:45
PiRKCommitted on Oct 2 2020, 08:57
PiRKPushed on Oct 2 2020, 08:57
Reviewer
Restricted Owners Package
Differential Revision
D7730: [rpc] deriveaddresses: add range to CRPCConvertParam
Parents
rABC5abfa6f26e60: remove some magic mining constants in functional tests
Branches
Unknown
Tags
Unknown