Page MenuHomePhabricator
Differential D6614

[backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges
ClosedPublic
Actions

Authored by majcosta on Jun 16 2020, 19:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd3875009a637: [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges
Summary

https://github.com/bitcoin/bitcoin/pull/15497/commits/ca253f6ebf2c9a12f5cb2b4c9f575178d058a612

Depends on D6613

Concludes backport of Core PR15497

Test Plan
ninja check
test_runner.py rpc_deriveaddresses

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 16 2020, 19:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 19:58
majcosta requested review of this revision.Jun 16 2020, 19:58
teamcity edited the summary of this revision. (Show Details)Jun 16 2020, 19:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11533: Diff 21473.Jun 16 2020, 20:12
majcosta added a child revision: D6615: [backport#15744] refactor: Extract ParseDescriptorRange.Jun 16 2020, 20:44
Fabien accepted this revision.Jun 17 2020, 09:29
This revision is now accepted and ready to land.Jun 17 2020, 09:29
Closed by commit rABCd3875009a637: [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 17 2020, 16:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd3875009a637: [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges.
PiRK mentioned this in D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.Oct 2 2020, 08:09
PiRK mentioned this in rABCb06d072c8a08: [rpc] deriveaddresses: add range to CRPCConvertParam.Oct 2 2020, 08:57

Revision Contents
Changeset List

PathSize
src/
rpc/
52 lines
test/
functional/
28 lines

Diff 21494

View Options

src/rpc/misc.cpp

Loading...
View Options

test/functional/rpc_deriveaddresses.py

Loading...