Page MenuHomePhabricator
Differential D6613

[backport#15497] Use stop/[start,stop] notation in importmulti desc range
ClosedPublic
Actions

Authored by majcosta on Jun 16 2020, 19:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC16524ee867d2: [backport#15497] Use stop/[start,stop] notation in importmulti desc range
Summary

https://github.com/bitcoin/bitcoin/pull/15497/commits/1675b7ce5559d4796c81cb18a522d242be34d996

Depends on D6612

Partial backport of Core PR15497

Test Plan
ninja check
test_runner.py wallet_importmulti

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 16 2020, 19:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 19:53
majcosta requested review of this revision.Jun 16 2020, 19:53
teamcity edited the summary of this revision. (Show Details)Jun 16 2020, 19:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6614: [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges.Jun 16 2020, 19:58
Harbormaster completed remote builds in B11532: Diff 21472.Jun 16 2020, 20:03
Fabien accepted this revision.Jun 17 2020, 09:24
Fabien added a subscriber: Fabien.

Out of scope for this diff, but please investigate why we don't have the # Test importing of a ranged descriptor without keys case like core

This revision is now accepted and ready to land.Jun 17 2020, 09:24
Closed by commit rABC16524ee867d2: [backport#15497] Use stop/[start,stop] notation in importmulti desc range (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyJun 17 2020, 15:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC16524ee867d2: [backport#15497] Use stop/[start,stop] notation in importmulti desc range.

Revision Contents
Changeset List

PathSize
src/
wallet/
26 lines
test/
functional/
2 lines

Diff 21493

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...