Page MenuHomePhabricator
Differential D6615

[backport#15744] refactor: Extract ParseDescriptorRange
ClosedPublic
Actions

Authored by majcosta on Jun 16 2020, 20:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6a6cec44cf14: [backport#15744] refactor: Extract ParseDescriptorRange
Summary

510c6532ba Extract ParseDescriptorRange (Ben Woosley)

Pull request description:

So as to be consistently informative when the checks fail, and
to protect against unintentional divergence among the checks.

Depends on D6614

Backport of Core PR15744

Test Plan
ninja check
test_runner.py wallet_importmulti rpc_scantxoutset

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 16 2020, 20:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 20:44
majcosta requested review of this revision.Jun 16 2020, 20:44
teamcity edited the summary of this revision. (Show Details)Jun 16 2020, 20:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11534: Diff 21474.Jun 16 2020, 20:57
Fabien accepted this revision.Jun 17 2020, 09:33
This revision is now accepted and ready to land.Jun 17 2020, 09:33
Closed by commit rABC6a6cec44cf14: [backport#15744] refactor: Extract ParseDescriptorRange (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 17 2020, 16:01
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC6a6cec44cf14: [backport#15744] refactor: Extract ParseDescriptorRange.

Revision Contents
Changeset List

PathSize
src/
rpc/
7 lines
17 lines
2 lines
20 lines
wallet/
10 lines
test/
functional/
38 lines
21 lines

Diff 21495

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

test/functional/rpc_scantxoutset.py

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...