Page MenuHomePhabricator
Differential D7730

[rpc] deriveaddresses: add range to CRPCConvertParam
ClosedPublic
Actions

Authored by PiRK on Oct 2 2020, 08:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb06d072c8a08: [rpc] deriveaddresses: add range to CRPCConvertParam
Summary

Related to D6614

Backport of Core PR15510

Test Plan
ninja && ninja check
sudo ninja install

Before:

$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
error code: -8
error message:
Unknown named parameter range

After:

$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
[
  "bitcoincash:qprtnzgt6eph9hh0ejsn508qjjhspcagsses6cmsf0",
  "bitcoincash:qpqmyerc9q5atsvqlx668ulur2s2le36qv996lljtt",
  "bitcoincash:qz338f4ef5kl8ygqcwg822m99nyydq4lju7mlv08ny",
  "bitcoincash:qqe9495xzm8g80z9cm3angqq9pcn3978c5xuj82h68"
]

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 2 2020, 08:09
Owners added a reviewer: Restricted Owners Package.Oct 2 2020, 08:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 08:09
PiRK requested review of this revision.Oct 2 2020, 08:09
teamcity edited the summary of this revision. (Show Details)Oct 2 2020, 08:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13146: Diff 24190.Oct 2 2020, 08:21
Fabien accepted this revision.Oct 2 2020, 08:32
This revision is now accepted and ready to land.Oct 2 2020, 08:32
Closed by commit rABCb06d072c8a08: [rpc] deriveaddresses: add range to CRPCConvertParam (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by PiRK). · Explain WhyOct 2 2020, 08:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb06d072c8a08: [rpc] deriveaddresses: add range to CRPCConvertParam.

Revision Contents
Changeset List

PathSize
src/
rpc/
3 lines
3 lines

Diff 24196

View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...