Page MenuHomePhabricator
Differential D7744

[refactor] replace global Params() use with CWallet chainParams member
AbandonedPublic
Actions

Authored by majcosta on Oct 2 2020, 14:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

as suggested in D7041. next diff replaces the member with a method that gets CChainParams from interfaces::Chain (where available)

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace_params_with_cwallet_params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13161
Build 26372: Build Difflint-circular-dependencies · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 26371: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 2 2020, 14:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 14:24
majcosta requested review of this revision.Oct 2 2020, 14:24
Harbormaster completed remote builds in B13160: Diff 24210.Oct 2 2020, 14:33
deadalnix requested changes to this revision.Oct 2 2020, 14:37
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/wallet.cpp
2302 ↗(On Diff #24210)

Same problem as D7736 . Also, why a new revision? That makes review harder.

This revision now requires changes to proceed.Oct 2 2020, 14:37
majcosta updated this revision to Diff 24211.Oct 2 2020, 14:47

addressed feedback

majcosta abandoned this revision.Oct 2 2020, 14:51

Apologies, I have no idea why there's a new revision. I'll just arc diff --update on the other one.

Harbormaster completed remote builds in B13161: Diff 24211.Oct 2 2020, 14:59

Revision Contents
Changeset List

PathSize
src/
wallet/
7 lines
29 lines
4 lines

Diff 24211

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...