Page MenuHomePhabricator

[refactor] allow access to ChainImpl's m_params via Chain interface
Needs RevisionPublic

Authored by majcosta on Sun, Jul 26, 12:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

as title

Test Plan
ninja check

Event Timeline

majcosta created this revision.Sun, Jul 26, 12:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jul 26, 12:47
majcosta requested review of this revision.Sun, Jul 26, 12:47
majcosta planned changes to this revision.Sun, Jul 26, 13:34

this might not be needed

majcosta requested review of this revision.Thu, Jul 30, 20:02
Fabien added a subscriber: Fabien.Fri, Jul 31, 08:47

What's the use case ?

deadalnix requested changes to this revision.Fri, Jul 31, 20:31
deadalnix added a subscriber: deadalnix.

@majcosta While I don't have anything against this per se, packaging it with some code that actually uses this would be beneficial. I assume to is about removing the params member of CWallet because it is redundant with the chain member. Here is what I suggest you do:

1/ Use the chain member in CWallet instead of param where possible without this change.
2/ Do this change with the removal of the param member in CWallet.

This revision now requires changes to proceed.Fri, Jul 31, 20:31