Page MenuHomePhabricator

[backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70)
ClosedPublic

Authored by majcosta on Oct 2 2020, 17:22.

Details

Summary

2f37163caf244acbe5fc715f2321aebc231522bc test: only include and init openSSL where it's actually used (fanquake)

Pull request description:

This should save initializing OpenSSL during tests if compiled with `--disable-bip70`.

Backport of Core PR16554

Test Plan

with -DENABLE_BIP70=[ON|OFF]:

ninja check check-functional

Event Timeline

majcosta requested review of this revision.Oct 2 2020, 17:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Oct 2 2020, 18:16
jasonbcox added a subscriber: jasonbcox.

You need to enable/disable BIP70 in the test plan.

src/qt/test/paymentservertests.cpp
18

These checks shouldn't be necessary. See qt/test/CMakeLists.txt

This revision now requires changes to proceed.Oct 2 2020, 18:16
majcosta edited the test plan for this revision. (Show Details)
majcosta removed a reviewer: jasonbcox.

you're right, no need for the preprocessor conditionals

jasonbcox added inline comments.
src/qt/test/paymentservertests.cpp
19 ↗(On Diff #24225)

errant newline

This revision is now accepted and ready to land.Oct 2 2020, 18:52