Updated build docs for OSX
ClosedPublic
Actions

Authored by jasonbcox on Dec 9 2017, 23:21.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

Summary

Ran into some issues building bitcoin-abc on OSX, so I updated the build docs accordingly. I also refactored them slightly to make more sense.

Test Plan

N/A

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Owners added a reviewer: Restricted Owners Package.Dec 9 2017, 23:21

deadalnix requested changes to this revision.Dec 10 2017, 14:18

deadalnix added inline comments.

doc/build-osx.md
33 ↗	(On Diff #2012)	I think you should keep that step.
43 ↗	(On Diff #2012)	It's a good idea to advice people to build out of tree.

This revision now requires changes to proceed.Dec 10 2017, 14:18

jasonbcox marked an inline comment as done.

jasonbcox added inline comments.

doc/build-osx.md
33 ↗	(On Diff #2012)	So I thought about this and I think you're right. My intent was to remove it and direct everyone to CONTRIBUTING.md for details on pulling source, but I realize most people aren't devs. In that light, this step should probably be added to build-unix and build-windows as well. I'll add this line back and tackle that in another diff.
43 ↗	(On Diff #2012)	Good point. I'll write this up in another diff so that it covers all of the build-* files. The recommendation should be on all platforms, imo. Opened a ticket so I don't forget: https://reviews.bitcoinabc.org/T129