Page MenuHomePhabricator

Add build bash script and a python script for reporting status
ClosedPublic

Authored by schancel on Dec 10 2017, 02:48.

Details

Summary

This commit adds a script build.sh which is expected to run the
build on teamcity.

Test Plan

run scripts locally

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This diff has suceeded [testing]().

This diff has succeeded testing.

Fix several small problems.

schancel mentioned this in Unknown Object (Maniphest Task).Dec 10 2017, 04:15

This revision has passed testing.

teamcity mentioned this in Unknown Object (Maniphest Task).Dec 10 2017, 04:30

This revision has passed testing.

Fix several bugs and add a small readme.

Set priority of tasks to unbreak

contrib/teamcity/build.sh
34 ↗(On Diff #2017)

I think you should make sure to build out of tree. You can also get a good value for j using

THREADS=$(grep -c ^processor /proc/cpuinfo)
contrib/teamcity/build.sh
37 ↗(On Diff #2017)

If the build fails, then what happens ?

contrib/teamcity/teamcitybot.py
114 ↗(On Diff #2017)

Considering anyone wo can modify this script can dump this token, it'd like to know what security measure are taken here.

120 ↗(On Diff #2017)

This is .arcconfig

contrib/teamcity/build.sh
37 ↗(On Diff #2017)

Can you be more specific? The trap report EXIT should get called on any error. I'm not capturing any build specific output though for compiler errors at this point.

contrib/teamcity/teamcitybot.py
114 ↗(On Diff #2017)

None at the moment, but we discussed out of band.

deadalnix requested changes to this revision.Dec 10 2017, 20:30
deadalnix added inline comments.
contrib/teamcity/teamcitybot.py
25 ↗(On Diff #2023)

This assume the file is at a certain place and will break if it is moved. It is also unclear what that place is because now it is 2 subfolder in, but there is only one set of ... Isn't there a way to get the root of the git repo and then get it from there ?

This revision now requires changes to proceed.Dec 10 2017, 20:30
contrib/teamcity/teamcitybot.py
25 ↗(On Diff #2023)

That's what this does. Isn't it always at the repo root?

25 ↗(On Diff #2023)

pygit2.discover_repository(".") returns something like /foo/bar/bob/bitcoin-abc/.git

deadalnix added inline comments.
contrib/teamcity/teamcitybot.py
25 ↗(On Diff #2023)

Alright.

This revision is now accepted and ready to land.Dec 11 2017, 00:16

Fixing the comment about the building outside of source tree.

Support building out of tree

This revision is now accepted and ready to land.Dec 11 2017, 04:12

Only build.sh was changed to support building out of tree.

This revision was automatically updated to reflect the committed changes.