Page MenuHomePhabricator
Differential D7760

build: Drop all of the ZeroMQ patches
ClosedPublic
Actions

Authored by Fabien on Oct 5 2020, 09:17.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCbcdc1c061edf: build: Drop all of the ZeroMQ patches
Summary
This PR gets rid of the all patches for ZeroMQ:
 - the Mingw-w64 5.0 (Ubuntu 18.04 bionic) is used to build the Windows
binaries
 - it is safe to use pthread_setname_np since #17538 when the minimal
glibc version is set to 2.17; see: #11986 (comment)

Note: Debian Buster has MinGw 6.0 and we enforce glibc >= 2.19.

Backport of core PR18405.

Test Plan
make build-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 5 2020, 09:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 09:17
Fabien requested review of this revision.Oct 5 2020, 09:17
teamcity edited the summary of this revision. (Show Details)Oct 5 2020, 09:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added inline comments.Oct 5 2020, 09:19
depends/packages/zeromq.mk
20 ↗(On Diff #24249)

Note to reviewers: the last line from the original PR is for the RISC-V cross build which we don't support.

Fabien added a comment.Oct 5 2020, 09:24

@bot gitian-linux gitian-osx gitian-win

Harbormaster completed remote builds in B13185: Diff 24249.Oct 5 2020, 09:26
Fabien added a child revision: D7763: build: improve sed robustness by not using sed.Oct 5 2020, 13:17
majcosta accepted this revision.Oct 5 2020, 14:20
This revision is now accepted and ready to land.Oct 5 2020, 14:20
Closed by commit rABCbcdc1c061edf: build: Drop all of the ZeroMQ patches (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 5 2020, 16:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbcdc1c061edf: build: Drop all of the ZeroMQ patches.

Revision Contents
Changeset List

Diff 24270

View Options

depends/packages/zeromq.mk

Loading...
View Options

depends/patches/zeromq/0001-fix-build-with-older-mingw64.patch

Loading...
View Options

depends/patches/zeromq/0002-disable-pthread_set_name_np.patch

Loading...