Page MenuHomePhabricator
Differential D7764

Avoid redefine warning
ClosedPublic
Actions

Authored by PiRK on Oct 5 2020, 13:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCe3963025846f: Avoid redefine warning
Summary

This removes a warning on the Windows build:
../../src/fs.cpp:13: warning: "NOMINMAX" redefined

Backport of Core PR15782

Test Plan

ninja && ninja check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 5 2020, 13:25
Owners added a reviewer: Restricted Owners Package.Oct 5 2020, 13:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 13:25
PiRK requested review of this revision.Oct 5 2020, 13:25
teamcity edited the summary of this revision. (Show Details)Oct 5 2020, 13:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13189: Diff 24253.Oct 5 2020, 13:33
Fabien accepted this revision.Oct 5 2020, 13:44
This revision is now accepted and ready to land.Oct 5 2020, 13:44
Closed by commit rABCe3963025846f: Avoid redefine warning (authored by Peter Bushnell <bushsolo@gmail.com>, committed by PiRK). · Explain WhyOct 5 2020, 13:45
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe3963025846f: Avoid redefine warning.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 24253

View Options

src/fs.cpp

Loading...