rpc: Validate maxfeerate with AmountFromValue
ClosedPublic
Actions

Authored by PiRK on Oct 5 2020, 15:54.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC5669673ce7b6: rpc: Validate maxfeerate with AmountFromValue

Summary

With this change maxfeerate can also be set as a string, accordingly to the help test:

maxfeerate (numeric or string,

Backport of Core PR15770

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 5 2020, 15:54

Owners added a reviewer: Restricted Owners Package.Oct 5 2020, 15:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2020, 15:54

PiRK requested review of this revision.Oct 5 2020, 15:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13193: Diff 24265.Oct 5 2020, 16:06

deadalnix accepted this revision.Oct 5 2020, 16:40

This revision is now accepted and ready to land.Oct 5 2020, 16:40

Closed by commit rABC5669673ce7b6: rpc: Validate maxfeerate with AmountFromValue (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 6 2020, 07:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5669673ce7b6: rpc: Validate maxfeerate with AmountFromValue.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

10 lines

test/

functional/

rpc_rawtransaction.py

4 lines

Diff 24288

View Options

src/rpc/rawtransaction.cpp