Page MenuHomePhabricator
Differential D7778

QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one
ClosedPublic
Actions

Authored by PiRK on Oct 6 2020, 10:20.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCa421408bfaca: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending…
Summary

PR description:

While this doesn't currently trigger any problems, the network protocol does expect headers to be sent connectable in normal circumstances, and if too many are sent out of order will disconnect the peer.

Backport of Core PR15897

Test Plan

ninja && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 6 2020, 10:20
Owners added a reviewer: Restricted Owners Package.Oct 6 2020, 10:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 10:20
PiRK requested review of this revision.Oct 6 2020, 10:20
teamcity edited the summary of this revision. (Show Details)Oct 6 2020, 10:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13203: Diff 24292.Oct 6 2020, 10:27
deadalnix accepted this revision.Oct 6 2020, 13:00
This revision is now accepted and ready to land.Oct 6 2020, 13:00
Closed by commit rABCa421408bfaca: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending… (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyOct 6 2020, 13:10
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa421408bfaca: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending….

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
3 lines

Diff 24295

View Options

test/functional/test_framework/mininode.py

Loading...