HomePhabricator

QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending…

Description

QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one

Summary:
PR description:

While this doesn't currently trigger any problems, the network protocol does expect headers to be sent connectable in normal circumstances, and if too many are sent out of order will disconnect the peer.

Backport of Core PR15897

Test Plan: ninja && ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7778

Details

Provenance
Luke Dashjr <luke-jr+git@utopios.org>Authored on Apr 23 2019, 19:30
PiRKCommitted on Oct 6 2020, 13:09
PiRKPushed on Oct 6 2020, 13:09
Reviewer
Restricted Owners Package
Differential Revision
D7778: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one
Parents
rABC5669673ce7b6: rpc: Validate maxfeerate with AmountFromValue
Branches
Unknown
Tags
Unknown