Correct units for "-dbcache" and "-prune"
AbandonedPublic
Actions

Authored by PiRK on Oct 6 2020, 13:50.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

All dbcache-related values in the code are measured in MiB (not in
megabytes, MB) or in bytes.
The GUI "-prune" values in GB are translated to the node values in MiB
correctly. The maximum of the "-prune" QSpinBox is not limited by the
default value of 99 (GB).
Also, this improves log readability.

Backport of Core PR15163
It also includes a commit that fixes a bug introduced by this PR: 4ddeb2f860eee98fbe94725ea8885368068a03f2

Test Plan

ninja && ninja check

Install bitcoin-qt, check that the prune QSpinBox widget is no longer limited to values < 99.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr15163

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13207
Build 26460: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-clang-tidy
Build 26459: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 6 2020, 13:50

Owners added a reviewer: Restricted Owners Package.Oct 6 2020, 13:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 13:50

PiRK requested review of this revision.Oct 6 2020, 13:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

include commit 4ddeb2f860eee98fbe94725ea8885368068a03f2 that fixes a bug in PR15163

Widget range was set after loading the user configuration. So possibly the configuration
was ignored if the value was above the default widget range 0--99

PiRK edited the summary of this revision. (Show Details)Oct 6 2020, 14:00

Harbormaster completed remote builds in B13206: Diff 24299.Oct 6 2020, 14:02

PiRK added a child revision: D7782: Correct units for "-dbcache" and "-prune" and upper prune limit.Oct 6 2020, 14:06

PiRK edited the summary of this revision. (Show Details)Oct 6 2020, 14:08

PiRK edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13207: Diff 24300.Oct 6 2020, 14:14

Because PR15801 fixes a bug introduced here, it make sense to merge both. What remain of PR15801 is trivial.

This revision now requires changes to proceed.Oct 6 2020, 14:58

I did as suggested, merged the last commit from D7782 into this diff. The resulting diff ended up being D7782, when I expected it to be this one. I will abandon D7781.