Page MenuHomePhabricator
Differential D7786

[CI] Remove the Openjdk 8 dependency
ClosedPublic
Actions

Authored by Fabien on Oct 6 2020, 16:02.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCc25d4aea2b33: [CI] Remove the Openjdk 8 dependency
Summary

This dependency was added to provide Teamcity support, however we don't
run Teamcity in our build containers. We still need a JDK for building
the JNI bindings, so let's use the debian default (Openjdk 11).

Test Plan

Run some CI builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 6 2020, 16:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 16:02
Fabien requested review of this revision.Oct 6 2020, 16:02
Fabien planned changes to this revision.
Fabien added a comment.Oct 6 2020, 16:04

@bot gitian-osx

Fabien added a comment.Oct 6 2020, 16:05

@bot build-secp256k1-java

Harbormaster completed remote builds in B13215: Diff 24308.Oct 6 2020, 16:18
Fabien requested review of this revision.Oct 6 2020, 17:48
jasonbcox requested changes to this revision.Oct 6 2020, 18:04
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
contrib/teamcity/setup-debian-buster.sh
99 ↗(On Diff #24308)

We can remove the script and the associated pubkey, probably.

This revision now requires changes to proceed.Oct 6 2020, 18:04
Fabien updated this revision to Diff 24313.Oct 6 2020, 18:41

Remove install script and pubkey as well

Harbormaster completed remote builds in B13218: Diff 24313.Oct 6 2020, 18:56
jasonbcox accepted this revision.Oct 6 2020, 20:34
This revision is now accepted and ready to land.Oct 6 2020, 20:34
Closed by commit rABCc25d4aea2b33: [CI] Remove the Openjdk 8 dependency (authored by Fabien). · Explain WhyOct 7 2020, 08:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc25d4aea2b33: [CI] Remove the Openjdk 8 dependency.

Revision Contents
Changeset List

Diff 24327

View Options

contrib/teamcity/adoptopenjdk.pub

Loading...
View Options

contrib/teamcity/install_openjdk8.sh

Loading...
View Options

contrib/teamcity/setup-debian-buster.sh

Loading...