Differential D7790

[backport#11138] Compat: Simplify bswap_16 implementation
ClosedPublic
Actions

Authored by majcosta on Oct 6 2020, 23:35.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC949723644e78: [backport#11138] Compat: Simplify bswap_16 implementation

Summary

e40fa98 Simplify bswap_16 implementation (danra)

Pull request description:

Simplify bswap_16 implementation on platforms which don't already have it defined.
This has no effect on the generated assembly; it just simplifies the source code.

Backport of Core PR11138

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 6 2020, 23:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2020, 23:35

majcosta requested review of this revision.Oct 6 2020, 23:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13221: Diff 24316.Oct 6 2020, 23:43

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

jasonbcox accepted this revision.Oct 7 2020, 01:13

This revision is now accepted and ready to land.Oct 7 2020, 01:13

Closed by commit rABC949723644e78: [backport#11138] Compat: Simplify bswap_16 implementation (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyOct 7 2020, 14:53

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC949723644e78: [backport#11138] Compat: Simplify bswap_16 implementation.

Revision Contents
Changeset List

Path

Size

src/

compat/

byteswap.h

2 lines

Diff 24336

View Options

[backport#11138] Compat: Simplify bswap_16 implementationClosedPublicActions