Page MenuHomePhabricator
Differential D7798

qt: Remove hidden columns in coin control dialog
ClosedPublic
Actions

Authored by PiRK on Oct 7 2020, 12:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC75362b2bb48a: qt: Remove hidden columns in coin control dialog
Summary

Store the data in specific roles instead of storing it as text in hidden columns.

Backport of Core PR14828

Test Plan

ninja && ninja check

Run src/qt/bitcoin-qt and verify that the empty columns at the end of the table are no longer there, in the Coin Selection dialog.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2020, 12:40
Owners added a reviewer: Restricted Owners Package.Oct 7 2020, 12:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 12:40
PiRK requested review of this revision.Oct 7 2020, 12:40
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 12:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

PiRK edited the summary of this revision. (Show Details)Oct 7 2020, 12:40
PiRK edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B13235: Diff 24333.Oct 7 2020, 12:48
Fabien edited the summary of this revision. (Show Details)Oct 7 2020, 16:05
deadalnix accepted this revision.Oct 7 2020, 18:35
This revision is now accepted and ready to land.Oct 7 2020, 18:35
Closed by commit rABC75362b2bb48a: qt: Remove hidden columns in coin control dialog (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 8 2020, 04:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC75362b2bb48a: qt: Remove hidden columns in coin control dialog.

Revision Contents
Changeset List

PathSize
src/
qt/
5 lines
24 lines
forms/
2 lines

Diff 24375

View Options

src/qt/coincontroldialog.h

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/forms/coincontroldialog.ui

Loading...