Page MenuHomePhabricator
Differential D7803

gui: Enable console line edit on setClientModel
ClosedPublic
Actions

Authored by PiRK on Oct 7 2020, 16:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC8ef33956015c: gui: Enable console line edit on setClientModel
Summary

It was possible to cause bitcoin-qt to crash by executing any command in menu Window > Console during startup.
This is fixed by disabling console line edit by default, and only enabling once RPCConsole::setClientModel is called.

Backport of Core PR16122

Test Plan

ninja && ninja check

Note: I wasn't able to reproduce the crash, I'm not able to reach the menu before the application is well started.
But I tested that the console is still usable after this diff.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 7 2020, 16:52
Owners added a reviewer: Restricted Owners Package.Oct 7 2020, 16:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 16:52
PiRK requested review of this revision.Oct 7 2020, 16:52
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 16:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13244: Diff 24350.Oct 7 2020, 17:15
deadalnix accepted this revision.Oct 7 2020, 18:35
This revision is now accepted and ready to land.Oct 7 2020, 18:35
Closed by commit rABC8ef33956015c: gui: Enable console line edit on setClientModel (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyOct 8 2020, 04:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8ef33956015c: gui: Enable console line edit on setClientModel.

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
3 lines
3 lines

Diff 24376

View Options

src/qt/forms/debugwindow.ui

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...