HomePhabricator

gui: Enable console line edit on setClientModel

Description

gui: Enable console line edit on setClientModel

Summary:
It was possible to cause bitcoin-qt to crash by executing any command in menu Window > Console during startup.
This is fixed by disabling console line edit by default, and only enabling once RPCConsole::setClientModel is called.

Backport of Core PR16122

Test Plan:
ninja && ninja check

Note: I wasn't able to reproduce the crash, I'm not able to reach the menu before the application is well started.
But I tested that the console is still usable after this diff.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7803

Details

Provenance
João Barbosa <joao.paulo.barbosa@gmail.com>Authored on May 29 2019, 21:53
PiRKCommitted on Oct 8 2020, 04:21
PiRKPushed on Oct 8 2020, 04:21
Reviewer
Restricted Owners Package
Differential Revision
D7803: gui: Enable console line edit on setClientModel
Parents
rABC75362b2bb48a: qt: Remove hidden columns in coin control dialog
Branches
Unknown
Tags
Unknown