Differential D7806

[backport#14934] Descriptor expansion cache clarifications
ClosedPublic
Actions

Authored by majcosta on Oct 7 2020, 18:51.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCa893aa1d9b34: [backport#14934] Descriptor expansion cache clarifications

Summary

2e68ffaf205866e4cea71f64e79bbfb89e17280a [doc] descriptor: explain GetPubKey() usage with cached public key (Sjors Provoost)
2290269759ad10cc2e35958c7b0a63f3a7608621 scripted-diff: rename DescriptorImpl m_script_arg to m_subdescriptor_arg (Sjors Provoost)

Pull request description:

I found the name `m_script_arg` to be confusing while reviewing https://github.com/bitcoin/bitcoin/pull/14646#discussion_r240677238. @sipa let me know if `m_subdescriptor_arg` is completely wrong.

I also added an explanation of why we call `GetPubKey` when we don't ask it for a public key.

ACKs for top commit:

laanwj:
  ACK 2e68ffaf205866e4cea71f64e79bbfb89e17280a

Backport of Core PR14934

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 7 2020, 18:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 18:51

majcosta requested review of this revision.Oct 7 2020, 18:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13247: Diff 24354.Oct 7 2020, 19:02

deadalnix accepted this revision.Oct 7 2020, 19:26

This revision is now accepted and ready to land.Oct 7 2020, 19:26

Closed by commit rABCa893aa1d9b34: [backport#14934] Descriptor expansion cache clarifications (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyOct 7 2020, 19:35

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa893aa1d9b34: [backport#14934] Descriptor expansion cache clarifications.

PiRK mentioned this in D7804: [backport#15024] Allow specific private keys to be derived from descriptor.Oct 13 2020, 12:22

Revision Contents
Changeset List

Path

Size

src/

script/

descriptor.h

8 lines

descriptor.cpp

40 lines

Diff 24360

View Options

src/script/descriptor.h