Page MenuHomePhabricator
Differential D7811

Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2]
ClosedPublic
Actions

Authored by jasonbcox on Oct 7 2020, 20:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd899b47131c5: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part…
Summary

7a2ecf16df938dd95d3130a46082def7a02338eb Wallet: Change IsMine check in CWallet::DelAddressBook from assert to failure (Luke Dashjr)
2952c46b923042f2de801f319e03ed5c4c4eb735 Wallet: Replace CAddressBookData.name with GetLabel() method (Luke Dashjr)
d7092c392e10889cd7a080b3d22ed6446a59b87a QA: Test that change doesn't turn into non-change when spent in an avoid-reuse wallet (Luke Dashjr)

Pull request description:

Follow-up to #18192, not strictly necessary for 0.20

Depends on D7810 and introduces tests for it too

Backport of Core PR18546

Test Plan

ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 7 2020, 20:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 20:44
jasonbcox requested review of this revision.Oct 7 2020, 20:44
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 20:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13252: Diff 24365.Oct 7 2020, 21:04
deadalnix accepted this revision.Oct 7 2020, 22:34
This revision is now accepted and ready to land.Oct 7 2020, 22:34
jasonbcox updated this revision to Diff 24422.Oct 8 2020, 21:56

Rebase

Harbormaster completed remote builds in B13283: Diff 24422.Oct 8 2020, 22:09
Closed by commit rABCd899b47131c5: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part… (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyOct 8 2020, 23:13
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCd899b47131c5: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part….

Revision Contents
Changeset List

PathSize
src/
interfaces/
5 lines
wallet/
2 lines
20 lines
test/
4 lines
4 lines
9 lines
test/
functional/
26 lines

Diff 24428

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/walletdb_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_avoidreuse.py

Loading...