Page MenuHomePhabricator
Differential D7818

Add 2nd arg to signrawtransactionwithkey examples
ClosedPublic
Actions

Authored by PiRK on Oct 8 2020, 10:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC577b84e3c894: Add 2nd arg to signrawtransactionwithkey examples
Summary

The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

This is a backport of PR16210

Test Plan

./src/bitcoin-cli help signrawtransactionwithkey must end with following examples:

Examples:
> bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 8 2020, 10:02
Owners added a reviewer: Restricted Owners Package.Oct 8 2020, 10:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 10:02
PiRK requested review of this revision.Oct 8 2020, 10:02
Harbormaster completed remote builds in B13263: Diff 24383.Oct 8 2020, 10:09
deadalnix accepted this revision.Oct 8 2020, 12:26
This revision is now accepted and ready to land.Oct 8 2020, 12:26
Closed by commit rABC577b84e3c894: Add 2nd arg to signrawtransactionwithkey examples (authored by dooglus, committed by PiRK). · Explain WhyOct 8 2020, 13:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC577b84e3c894: Add 2nd arg to signrawtransactionwithkey examples.
PiRK edited the summary of this revision. (Show Details)Nov 11 2020, 10:02

Revision Contents
Changeset List

PathSize
src/
rpc/
7 lines

Diff 24388

View Options

src/rpc/rawtransaction.cpp

Loading...