Page MenuHomePhabricator
Differential D7824

[buildbot] Fix getIgnoreList dangling arg
ClosedPublic
Actions

Authored by jasonbcox on Oct 8 2020, 17:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1fca0f0b7b2e: [buildbot] Fix getIgnoreList dangling arg
Summary

Missed during cleanup of D7787 that wasn't caught by tests
because this method was mocked for all tests that called it.

Test Plan

pytest

Diff Detail

Event Timeline

jasonbcox created this revision.Oct 8 2020, 17:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 17:05
jasonbcox requested review of this revision.Oct 8 2020, 17:05
Fabien added a subscriber: Fabien.Oct 8 2020, 17:35
Fabien added inline comments.
contrib/buildbot/test/test_teamcity.py
32

Copy and paste error ?

jasonbcox updated this revision to Diff 24404.Oct 8 2020, 17:37

Fix copy-paste error

Harbormaster completed remote builds in B13271: Diff 24403.Oct 8 2020, 17:38
Harbormaster completed remote builds in B13272: Diff 24404.Oct 8 2020, 17:56
Fabien accepted this revision.Oct 8 2020, 17:57
This revision is now accepted and ready to land.Oct 8 2020, 17:57
Closed by commit rABC1fca0f0b7b2e: [buildbot] Fix getIgnoreList dangling arg (authored by jasonbcox). · Explain WhyOct 8 2020, 17:59
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1fca0f0b7b2e: [buildbot] Fix getIgnoreList dangling arg.

Revision Contents
Changeset List

PathSize
contrib/
buildbot/
2 lines
test/
8 lines

Diff 24403

View Options

contrib/buildbot/teamcity_wrapper.py

Loading...
View Options

contrib/buildbot/test/test_teamcity.py

Loading...