Page MenuHomePhabricator
Differential D7828

[backport#14161] doc/descriptors.md tweaks
ClosedPublic
Actions

Authored by majcosta on Oct 8 2020, 20:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0d6142d8ec26: [backport#14161] doc/descriptors.md tweaks
Summary

eeeaa29214 descriptors.md: Refer to descriptors as describing instead of matching (Russell Yanofsky)
eb49412562 doc/descriptors.md tweaks (Russell Yanofsky)

Pull request description:

Add some implementation details, and tweak phrasing in examples section to be more explicit about how expressions are used for matching.

Backport of Core PR14161

Test Plan
read it

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 8 2020, 20:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2020, 20:10
majcosta requested review of this revision.Oct 8 2020, 20:10
teamcity edited the summary of this revision. (Show Details)Oct 8 2020, 20:10
Fabien requested changes to this revision.Oct 8 2020, 20:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/descriptors.md
37 ↗(On Diff #24412)

No P2WPKH nor P2SH-P2WPKH

This revision now requires changes to proceed.Oct 8 2020, 20:16
Harbormaster completed remote builds in B13276: Diff 24412.Oct 8 2020, 20:23
majcosta updated this revision to Diff 24417.Oct 8 2020, 20:48

removed irrelevant segwit references

Fabien accepted this revision.Oct 8 2020, 21:03
This revision is now accepted and ready to land.Oct 8 2020, 21:03
Harbormaster completed remote builds in B13280: Diff 24417.Oct 8 2020, 21:07
majcosta added a child revision: D7832: [backport#17056] descriptors: Introduce sortedmulti descriptor.Oct 8 2020, 21:20
Closed by commit rABC0d6142d8ec26: [backport#14161] doc/descriptors.md tweaks (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyOct 8 2020, 21:21
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC0d6142d8ec26: [backport#14161] doc/descriptors.md tweaks.

Revision Contents
Changeset List

PathSize
doc/
27 lines

Diff 24420

View Options

doc/descriptors.md

Loading...