Differential D7923

Only run UpgradeWallet if the wallet needs to be upgraded
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 00:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1a996fb25ce6: Only run UpgradeWallet if the wallet needs to be upgraded

Summary

Backport of Core PR15761 [2/6] : https://github.com/bitcoin/bitcoin/pull/15761/commits/183323712398e26ddcf3a9dc048aaa9900a91f5a

Depends on D7922

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 15 2020, 00:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 00:32

deadalnix requested review of this revision.Oct 15 2020, 00:32

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 00:32

deadalnix edited the summary of this revision. (Show Details)Oct 15 2020, 00:32

deadalnix added a parent revision: D7922: Move wallet upgrading to its own function.

deadalnix added a child revision: D7924: Have UpgradeWallet take the version to upgrade to and an error message out parameter.Oct 15 2020, 00:34

deadalnix edited the summary of this revision. (Show Details)Oct 15 2020, 00:37

Harbormaster completed remote builds in B13404: Diff 24634.Oct 15 2020, 00:45

Fabien accepted this revision.Oct 15 2020, 06:21

This revision is now accepted and ready to land.Oct 15 2020, 06:21

Closed by commit rABC1a996fb25ce6: Only run UpgradeWallet if the wallet needs to be upgraded (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 15 2020, 11:34

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1a996fb25ce6: Only run UpgradeWallet if the wallet needs to be upgraded.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

2 lines

wallet.cpp

76 lines

Diff 24648

View Options

src/wallet/wallet.h