Differential D7924

Have UpgradeWallet take the version to upgrade to and an error message out parameter
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 00:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCddb1c65648de: Have UpgradeWallet take the version to upgrade to and an error message out…

Summary

Backport of Core PR15761 [3/6] : https://github.com/bitcoin/bitcoin/pull/15761/commits/c988f27937bc79c90f4eed48552c72f1b66dc044

Depends on D7923

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15761-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13405
Build 26844: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26843: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 15 2020, 00:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 00:34

deadalnix requested review of this revision.Oct 15 2020, 00:34

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 00:34

deadalnix added a child revision: D7925: Make UpgradeWallet a member function of CWallet.Oct 15 2020, 00:35

deadalnix edited the summary of this revision. (Show Details)Oct 15 2020, 00:38

Harbormaster completed remote builds in B13405: Diff 24635.Oct 15 2020, 00:52

Fabien accepted this revision.Oct 15 2020, 06:22

This revision is now accepted and ready to land.Oct 15 2020, 06:22

Closed by commit rABCddb1c65648de: Have UpgradeWallet take the version to upgrade to and an error message out… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 15 2020, 11:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCddb1c65648de: Have UpgradeWallet take the version to upgrade to and an error message out….

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

2 lines

wallet.cpp

7 lines

Diff 24635

View Options

src/wallet/wallet.h