Remove "Restore" action in the Window menu, and show the "Main Window" action only on Mac.
Backport of Core PR16735
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC5eef6d1194ec: GUI: Remove unused menu items for Windows and Linux
ninja && ninja check
Run src/qt/bitcoin-qt -regtest and confirm that the menu and remaining actions still work as expected.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Snippet of first build failure:
[349/408] bitcoin: testing settings_tests [350/408] Running utility command for check-bitcoin-settings_tests [351/408] bitcoin: testing uint256_tests [352/408] Running utility command for check-bitcoin-uint256_tests [353/408] bitcoin: testing sigencoding_tests [354/408] bitcoin: testing undo_tests [355/408] bitcoin: testing walletdb_tests [356/408] Running utility command for check-bitcoin-sigencoding_tests [357/408] Running utility command for check-bitcoin-undo_tests [358/408] Running utility command for check-bitcoin-walletdb_tests [359/408] bitcoin: testing compilerbug_tests [360/408] bitcoin: testing checkpoints_tests [361/408] Running utility command for check-bitcoin-compilerbug_tests [362/408] bitcoin: testing validationinterface_tests [363/408] Running utility command for check-bitcoin-checkpoints_tests [364/408] Running utility command for check-bitcoin-validationinterface_tests [365/408] bitcoin: testing serialize_tests [366/408] Running utility command for check-bitcoin-serialize_tests [367/408] bitcoin: testing script_standard_tests [368/408] Running utility command for check-bitcoin-script_standard_tests [369/408] bitcoin: testing radix_tests [370/408] bitcoin: testing txvalidationcache_tests [371/408] Running utility command for check-bitcoin-radix_tests [372/408] Running utility command for check-bitcoin-txvalidationcache_tests [373/408] bitcoin: testing crypto_tests [374/408] bitcoin: testing blockcheck_tests [375/408] bitcoin: testing ismine_tests [376/408] Running utility command for check-bitcoin-crypto_tests [377/408] bitcoin: testing cashaddr_tests [378/408] bitcoin: testing blockstatus_tests [379/408] Running utility command for check-bitcoin-blockcheck_tests [380/408] Running utility command for check-bitcoin-ismine_tests [381/408] bitcoin: testing versionbits_tests [382/408] Running utility command for check-bitcoin-blockstatus_tests [383/408] Running utility command for check-bitcoin-cashaddr_tests [384/408] Running utility command for check-bitcoin-versionbits_tests [385/408] bitcoin: testing validation_block_tests [386/408] Running utility command for check-bitcoin-validation_block_tests [387/408] bitcoin: testing bswap_tests [388/408] bitcoin: testing script_tests [389/408] bitcoin: testing validation_tests [390/408] Running utility command for check-bitcoin-bswap_tests [391/408] Running utility command for check-bitcoin-script_tests [392/408] Running utility command for check-bitcoin-validation_tests [393/408] bitcoin: testing skiplist_tests [394/408] bitcoin: testing cuckoocache_tests [395/408] Running utility command for check-bitcoin-skiplist_tests [396/408] Running utility command for check-bitcoin-cuckoocache_tests [397/408] bitcoin: testing monolith_opcodes_tests [398/408] Running utility command for check-bitcoin-monolith_opcodes_tests [399/408] bitcoin: testing util_tests [400/408] Running utility command for check-bitcoin-util_tests [401/408] bitcoin: testing op_reversebytes_tests [402/408] Running utility command for check-bitcoin-op_reversebytes_tests [403/408] bitcoin: testing transaction_tests [404/408] Running utility command for check-bitcoin-transaction_tests [405/408] bitcoin: testing coins_tests [406/408] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1
Comment Actions
I'm unable to reproduce the failure locally.
I tried:
cmake .. -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DENABLE_CLANG_TIDY=ON ninja ninja check