HomePhabricator

[backport#17579] [refactor] Merge getreceivedby tally into GetReceived function

Description

[backport#17579] [refactor] Merge getreceivedby tally into GetReceived function

Summary:
a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25 Merge getreceivedby tally into GetReceived function (Andrew Toth)

Pull request description:

This PR merges the tally code of `getreceivedbyaddress` and `getreceivedbylabel` into a single function `GetReceived`. This reduces repeated code and makes it similar to `listreceivedbyaddress` and `listreceivedbylabel`, which use the function `ListReceived`. It will also make the change in #14707 simpler and easier to review.

ACKs for top commit:

theStack:
  re-ACK https://github.com/bitcoin/bitcoin/commit/a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25
meshcollider:
  utACK a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25

Backport of Core PR17579

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7939

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Apr 20 2020, 14:04
majcostaCommitted on Oct 15 2020, 17:29
majcostaPushed on Oct 15 2020, 17:29
Reviewer
Restricted Project
Differential Revision
D7939: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function
Parents
rABCa6b0545ead7a: [land-bot] Queue the HEAD revision by default
Branches
Unknown
Tags
Unknown