Differential D7939

[backport#17579] [refactor] Merge getreceivedby tally into GetReceived function
ClosedPublic
Actions

Authored by majcosta on Oct 15 2020, 16:10.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfa57b76ebd76: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function

Summary

a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25 Merge getreceivedby tally into GetReceived function (Andrew Toth)

Pull request description:

This PR merges the tally code of `getreceivedbyaddress` and `getreceivedbylabel` into a single function `GetReceived`. This reduces repeated code and makes it similar to `listreceivedbyaddress` and `listreceivedbylabel`, which use the function `ListReceived`. It will also make the change in #14707 simpler and easier to review.

ACKs for top commit:

theStack:
  re-ACK https://github.com/bitcoin/bitcoin/commit/a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25
meshcollider:
  utACK a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25

Backport of Core PR17579

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 15 2020, 16:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 16:10

majcosta requested review of this revision.Oct 15 2020, 16:10

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 16:10

majcosta mentioned this in D7937: [wallet] Move methods from Chain::Lock interface to simple Chain.Oct 15 2020, 16:16

Harbormaster completed remote builds in B13423: Diff 24665.Oct 15 2020, 16:20

jasonbcox accepted this revision.Oct 15 2020, 16:38

This revision is now accepted and ready to land.Oct 15 2020, 16:38

Closed by commit rABCfa57b76ebd76: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyOct 15 2020, 17:29

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCfa57b76ebd76: [backport#17579] [refactor] Merge getreceivedby tally into GetReceived function.

Revision Contents
Changeset List

Path

Size

src/

wallet/

132 lines

Diff 24671

src/wallet/rpcwallet.cpp

Loading...