Page MenuHomePhabricator
Differential D7937

[wallet] Move methods from Chain::Lock interface to simple Chain
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 14:51.

Details

Reviewers
majcosta
Fabien
Group Reviewers
Restricted Project
Commits
rABC731b33f5dec6: [wallet] Move methods from Chain::Lock interface to simple Chain
Summary

Remove findPruned and findFork, no more used after 17954.

Backport of Core PR16426 part [4/5] : https://github.com/bitcoin/bitcoin/pull/16426/commits/841178820d31e1c24a00cb2c8fc0b1fd2f126f56

Depends on D7936

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 15 2020, 14:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 14:51
deadalnix requested review of this revision.Oct 15 2020, 14:51
teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 14:52
deadalnix added a child revision: D7938: [wallet] Remove locked_chain from CWallet, its RPCs and tests.Oct 15 2020, 14:54
Harbormaster completed remote builds in B13420: Diff 24662.Oct 15 2020, 15:06
majcosta accepted this revision.Oct 15 2020, 16:16
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/rpcwallet.cpp
725 ↗(On Diff #24662)

not blocking because D7939 is in the pipeline. same for line 799.

This revision is now accepted and ready to land.Oct 15 2020, 16:16
Fabien accepted this revision.Oct 15 2020, 16:18
deadalnix updated this revision to Diff 24684.Oct 15 2020, 21:47

rebase and fix merge conflicts

This revision was landed with ongoing or failed builds.Oct 15 2020, 22:00
Closed by commit rABC731b33f5dec6: [wallet] Move methods from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC731b33f5dec6: [wallet] Move methods from Chain::Lock interface to simple Chain.
Harbormaster completed remote builds in B13433: Diff 24684.Oct 15 2020, 22:01
Fabien mentioned this in D7947: Fix missing lock in the chain interface.Oct 16 2020, 07:45
Fabien mentioned this in rABCa1d59f5a1455: Fix missing lock in the chain interface.Oct 16 2020, 13:23

Revision Contents
Changeset List

PathSize
src/
interfaces/
62 lines
93 lines
15 lines
wallet/
21 lines
test/
10 lines
11 lines
47 lines

Diff 24687

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...