Differential D7938

[wallet] Remove locked_chain from CWallet, its RPCs and tests
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 14:54.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1cb2090b019b: [wallet] Remove locked_chain from CWallet, its RPCs and tests

Summary

This change is intended to make the bitcoin node and its rpc, network
and gui interfaces more responsive while the wallet is in use. Currently
because the node's cs_main mutex is always locked before the wallet's
cs_wallet mutex (to prevent deadlocks), cs_main currently stays locked
while the wallet does relatively slow things like creating and listing
transactions.

This commit only remmove chain lock tacking in wallet code, and invert
lock order from cs_main, cs_wallet to cs_wallet, cs_main.
must happen at once to avoid any deadlock. Previous commit were only
removing Chain::Lock methods to Chain interface and enforcing they
take cs_main.

Remove LockChain method from CWallet and Chain::Lock interface.

Backport of Core PR16426 part [5/5] : https://github.com/bitcoin/bitcoin/pull/16426/commits/6a72f26968cf931c985d8d4797b6264274cabd06

Depends on D7937

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 15 2020, 14:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 14:54

deadalnix requested review of this revision.Oct 15 2020, 14:54

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 14:54

Harbormaster completed remote builds in B13421: Diff 24663.Oct 15 2020, 15:13

majcosta requested changes to this revision.Oct 15 2020, 17:27

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/wallet/test/wallet_tests.cpp
632 ↗	(On Diff #24663)	There's a pretty big out of order backport gap after this. Maybe creating a task/reminder to revisit this PR after 18115 and 18727 are landed is a good idea.