Differential D7935

[wallet] Move getBlockHeight from Chain::Lock interface to simple Chain
ClosedPublic
Actions

Authored by deadalnix on Oct 15 2020, 14:47.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC87c5aec9b3ee: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain

Summary

Add HaveChain to assert chain access for wallet-tool in LoadToWallet.

Backport of Core PR16426 part [2/5] : https://github.com/bitcoin/bitcoin/pull/16426/commits/de13363a472ea30dff2f8f55c6ae572281115380

Depends on D7934

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 15 2020, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 14:47

deadalnix requested review of this revision.Oct 15 2020, 14:47

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 14:47

deadalnix added a child revision: D7936: [wallet] Move getBlockHash from Chain::Lock interface to simple Chain.Oct 15 2020, 14:49

Harbormaster completed remote builds in B13418: Diff 24660.Oct 15 2020, 14:59

majcosta accepted this revision.Oct 15 2020, 15:16

This revision is now accepted and ready to land.Oct 15 2020, 15:16

Closed by commit rABC87c5aec9b3ee: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain (authored by Antoine Riard <ariard@student.42.fr>, committed by deadalnix). · Explain WhyOct 15 2020, 21:20

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC87c5aec9b3ee: [wallet] Move getBlockHeight from Chain::Lock interface to simple Chain.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

chain.h

10 lines

chain.cpp

16 lines

wallet/

wallet.h

3 lines

wallet.cpp

8 lines

Diff 24682

View Options

src/interfaces/chain.h

View Options

src/interfaces/chain.cpp

View Options

src/wallet/wallet.h

View Options

[wallet] Move getBlockHeight from Chain::Lock interface to simple ChainClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24682

src/interfaces/chain.h

src/interfaces/chain.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[wallet] Move getBlockHeight from Chain::Lock interface to simple Chain
ClosedPublic
Actions

Revision Contents
Changeset List