Page MenuHomePhabricator

[backport#17579] [refactor] Merge getreceivedby tally into GetReceived function
ClosedPublic

Authored by majcosta on Oct 15 2020, 16:10.

Details

Summary

a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25 Merge getreceivedby tally into GetReceived function (Andrew Toth)

Pull request description:

This PR merges the tally code of `getreceivedbyaddress` and `getreceivedbylabel` into a single function `GetReceived`. This reduces repeated code and makes it similar to `listreceivedbyaddress` and `listreceivedbylabel`, which use the function `ListReceived`. It will also make the change in #14707 simpler and easier to review.

ACKs for top commit:

theStack:
  re-ACK https://github.com/bitcoin/bitcoin/commit/a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25
meshcollider:
  utACK a1d5b12ec07d2f7aa9fa955a6dd99e8a2be5cb25

Backport of Core PR17579

Test Plan
ninja all check check-functional