Paths

Table of Contentst

refactor: pcoinsTip -> CChainState::CoinsTip()
AbandonedPublic
Actions

Authored by PiRK on Oct 15 2020, 17:10.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

This aliasing makes subsequent commits easier to review; eventually CoinsTip()
will return the CCoinsViewCache managed by CChainState.

Partial backport of Core PR16443 - part 1 of 3

Commit fae6ab6

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr16443

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/net_processing.cpp:1632	CPPCHECK	mismatchingContainers

Unit

No Test Coverage

Build Status

Buildable 13426
Build 26885: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang · build-diff
Build 26884: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 15 2020, 17:10

Owners added a reviewer: Restricted Owners Package.Oct 15 2020, 17:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 17:10

PiRK requested review of this revision.Oct 15 2020, 17:10

Harbormaster completed remote builds in B13426: Diff 24669.Oct 15 2020, 17:10

teamcity edited the summary of this revision. (Show Details)Oct 15 2020, 17:11

PiRK added a subscriber: Fabien.Oct 15 2020, 17:12

PiRK added inline comments.

src/net_processing.cpp
1632	I do not understand that lint error. We discussed it yesterday with @Fabien, who could not reproduce it with other versions of cppcheck

PiRK edited the summary of this revision. (Show Details)Oct 15 2020, 17:14

Abandoned because Marco worked on it already: D7580

Revision Contents
Changeset List

Path

Size

src/

interfaces/

node.cpp

2 lines

net_processing.cpp

10 lines

node/

coin.cpp

3 lines

transaction.cpp

2 lines

rest.cpp

4 lines

rpc/

blockchain.cpp

12 lines

rawtransaction.cpp

7 lines

test/

miner_tests.cpp

7 lines

txvalidationcache_tests.cpp

64 lines

txmempool.h

10 lines

validation.h

15 lines

validation.cpp

47 lines

test/

functional/

feature_dbcrash.py

2 lines

Diff 24669

View Options

src/interfaces/node.cpp

View Options

src/net_processing.cpp

View Options

src/node/coin.cpp

View Options

src/node/transaction.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/txmempool.h

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/feature_dbcrash.py

refactor: pcoinsTip -> CChainState::CoinsTip()AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24669

src/interfaces/node.cpp

src/net_processing.cpp

src/node/coin.cpp

src/node/transaction.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/test/miner_tests.cpp

src/test/txvalidationcache_tests.cpp

src/txmempool.h

src/validation.h

src/validation.cpp

test/functional/feature_dbcrash.py

refactor: pcoinsTip -> CChainState::CoinsTip()
AbandonedPublic
Actions

Revision Contents
Changeset List