Page MenuHomePhabricator

refactor: pcoinsTip -> CChainState::CoinsTip()
AbandonedPublic

Authored by PiRK on Thu, Oct 15, 17:10.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This aliasing makes subsequent commits easier to review; eventually CoinsTip()
will return the CCoinsViewCache managed by CChainState.

Partial backport of Core PR16443 - part 1 of 3

Commit fae6ab6

Test Plan

ninja && ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backport-pr16443
Lint
Lint ErrorsExcuse: I'm getting a lint error Iterators of different containers are used together.
SeverityLocationCodeMessage
Errorsrc/net_processing.cpp:1632CPPCHECKmismatchingContainers
Unit
No Unit Test Coverage
Build Status
Buildable 13426
Build 26885: Build Difflint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang · build-diff
Build 26884: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Thu, Oct 15, 17:10
PiRK requested review of this revision.Thu, Oct 15, 17:10
PiRK added inline comments.
src/net_processing.cpp
1632

I do not understand that lint error. We discussed it yesterday with @Fabien, who could not reproduce it with other versions of cppcheck

Abandoned because Marco worked on it already: D7580