Differential D7580

CChainState::CoinsTip()
ClosedPublic
Actions

Authored by majcosta on Sep 27 2020, 20:14.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()

Summary

This aliasing makes subsequent commits easier to review; eventually CoinsTip()
will return the CCoinsViewCache managed by CChainState.

https://github.com/bitcoin/bitcoin/pull/16443/commits/fae6ab6aed3b9fdc9201bb19a307dfc3d9b89891

Depends on D7578 and D7579

Partial backport of Core PR16443

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 27 2020, 20:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 20:14

majcosta requested review of this revision.Sep 27 2020, 20:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12940: Diff 23830.Sep 27 2020, 20:22

rebase

majcosta added a child revision: D7581: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState.Sep 27 2020, 20:43

Harbormaster completed remote builds in B12942: Diff 23832.Sep 27 2020, 20:47

deadalnix accepted this revision.Sep 27 2020, 22:05

This revision is now accepted and ready to land.Sep 27 2020, 22:05

majcosta mentioned this in T1084: Refactor pruning related code from validation.cpp.Oct 1 2020, 14:53

PiRK mentioned this in D7941: refactor: pcoinsTip -> CChainState::CoinsTip().Oct 15 2020, 17:42

Closed by commit rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip() (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhyOct 15 2020, 23:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip().

Revision Contents
Changeset List

Path

Size

src/

interfaces/

node.cpp

2 lines

net_processing.cpp

10 lines

node/

coin.cpp

3 lines

transaction.cpp

2 lines

rest.cpp

4 lines

rpc/

blockchain.cpp

12 lines

rawtransaction.cpp

7 lines

test/

miner_tests.cpp

7 lines

txvalidationcache_tests.cpp

63 lines

4 lines

4 lines

12 lines

47 lines

test/

functional/

feature_dbcrash.py

2 lines

Diff 24695

View Options

src/interfaces/node.cpp

View Options

src/net_processing.cpp

View Options

src/node/coin.cpp

View Options

src/node/transaction.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/feature_dbcrash.py

[backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24695

src/interfaces/node.cpp

src/net_processing.cpp

src/node/coin.cpp

src/node/transaction.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/test/miner_tests.cpp

src/test/txvalidationcache_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.h

src/validation.cpp

test/functional/feature_dbcrash.py

[backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()
ClosedPublic
Actions

Revision Contents
Changeset List