Page MenuHomePhabricator
Differential D7580

[backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()
ClosedPublic
Actions

Authored by majcosta on Sep 27 2020, 20:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()
Summary

This aliasing makes subsequent commits easier to review; eventually CoinsTip()
will return the CCoinsViewCache managed by CChainState.

https://github.com/bitcoin/bitcoin/pull/16443/commits/fae6ab6aed3b9fdc9201bb19a307dfc3d9b89891

Depends on D7578 and D7579

Partial backport of Core PR16443

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 27 2020, 20:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 20:14
majcosta requested review of this revision.Sep 27 2020, 20:14
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 20:14

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12940: Diff 23830.Sep 27 2020, 20:22
majcosta updated this revision to Diff 23832.Sep 27 2020, 20:37

rebase

majcosta added a child revision: D7581: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState.Sep 27 2020, 20:43
Harbormaster completed remote builds in B12942: Diff 23832.Sep 27 2020, 20:47
deadalnix accepted this revision.Sep 27 2020, 22:05
This revision is now accepted and ready to land.Sep 27 2020, 22:05
majcosta mentioned this in T1084: Refactor pruning related code from validation.cpp.Oct 1 2020, 14:53
PiRK mentioned this in D7941: refactor: pcoinsTip -> CChainState::CoinsTip().Oct 15 2020, 17:42
Closed by commit rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip() (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhyOct 15 2020, 23:57
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip().

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
10 lines
node/
3 lines
2 lines
4 lines
rpc/
12 lines
7 lines
test/
7 lines
71 lines
4 lines
4 lines
12 lines
47 lines
test/
functional/
2 lines

Diff 23832

View Options

src/interfaces/node.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/coin.cpp

Loading...
View Options

src/node/transaction.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/feature_dbcrash.py

Loading...