Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC59239db2aa64: Fix a potential use after move

Summary

When checking the tx inputs with CheckInputs(), the signature check
count is expected to be 0 when pvChecks is non null. This diff fixes
the current implementation which used the check variable after a move
to increment the sig check count with 0.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_use_after_move

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13434
Build 26900: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26899: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 15 2020, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2020, 19:18

Fabien requested review of this revision.Oct 15 2020, 19:19

Harbormaster completed remote builds in B13432: Diff 24679.Oct 15 2020, 19:32

deadalnix accepted this revision.Oct 15 2020, 21:34

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/validation.cpp
1074 ↗	(On Diff #24679)	Remove the else.

This revision is now accepted and ready to land.Oct 15 2020, 21:34

deadalnix requested changes to this revision.Oct 15 2020, 21:45

deadalnix added inline comments.

src/validation.cpp
1074 ↗	(On Diff #24679)	And add a comment about what is going on.

This revision now requires changes to proceed.Oct 15 2020, 21:45

Remove the useless else

deadalnix requested changes to this revision.Oct 15 2020, 21:52

deadalnix added inline comments.

src/validation.cpp
1076	You need to add a comment explaining the flow here because it is confusing.

This revision now requires changes to proceed.Oct 15 2020, 21:52

Harbormaster completed remote builds in B13434: Diff 24685.Oct 15 2020, 22:09

Attempt to explain the flow

deadalnix requested changes to this revision.Oct 15 2020, 22:22

deadalnix added inline comments.

src/validation.cpp
1073 ↗	(On Diff #24689)	The sigcheck will definitively be counted. his comment is at best misleading.
1079 ↗	(On Diff #24689)	Anyone who ends up here can read the code. Repeating the code in English doesn't help. There is a reason WHY the code is structured this way. This is what you need to explain.